jacktengg commented on PR #69304:
URL: https://github.com/apache/doris/pull/69304#issuecomment-6946277917
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69304
commit: a5161049d379795e9930c374484dab953114bb52
base: afd67a2d0fc8417a6fd0d86bb7bf98e3712e7e90
reviewed_at: 2026-11-17T19:06+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- All four existing threads are fixed at this commit: the legacy adapter
forwards spill capabilities and AI statistics; both streaming writers count
skipped NULL rows once; nullable byte merging preserves nested direct DISTINCT
merging.
- `be/src/exprs/aggregate/aggregate_function_null_v2.h:261` — version-20
bitmap no-input markers require upgraded readers and compactors. Keep execution
version 19 during rolling upgrade before new-format writes; lowering it
afterwards does not downgrade stored metadata or bytes.
- Read-only review covered all 58 changed files. Existing artifacts report
511 ASAN tests and 132 benchmark smoke cases; this review ran no builds/tests.
The earlier 21-suite SQL run and full performance archives are historical
evidence, not final-head runtime/performance validation.
- PR-description follow-up: remove obsolete links to the docs removed from
this PR, refresh validation counts, and label the earlier performance commits
as historical instead of final-source. This is a nonblocking metadata
correction outside the source finding count.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]