jacktengg commented on PR #69304:
URL: https://github.com/apache/doris/pull/69304#issuecomment-6948422165
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69304
commit: 61672d4406227238f4f70d2a63603a189e0ccbc5
base: afd67a2d0fc8417a6fd0d86bb7bf98e3712e7e90
reviewed_at: 2026-11-17T20:45+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/benchmark/nullable_allocation_counter.cpp:53` — The only change since
the a516104 review replaces escaped literals with equivalent raw literals.
Decoded text, operand order and newline are identical; all 216 archived
allocation records parse.
- `be/src/exprs/aggregate/aggregate_function_legacy_nullable.h:60` — All
four existing inline comments remain fixed. Full 58-file coverage reconfirmed
all 12 prior dismissals; no new source findings.
- `be/src/exprs/aggregate/aggregate_function_null_v2.h:80` — Keep version 19
throughout a mixed deployment. Version-20 state metadata/bitmap markers require
upgraded readers and compactors; lowering the query pin after new writes does
not downgrade stored data.
- `fe/fe-type/src/main/java/org/apache/doris/catalog/AggStateType.java:86` —
New archived FE44, SQL21, actual mixed-version Exchange, full-compaction and
FE-replay records cover a516104 production sources, identical to this head.
This review was read-only. Current binaries were rebuilt; full performance
comparison remains pending. The prior PR-description metadata follow-up is
resolved.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]