Gabriel39 commented on code in PR #70675:
URL: https://github.com/apache/doris/pull/70675#discussion_r4609657478


##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergManifestCache.java:
##########
@@ -209,22 +212,38 @@ Set<Integer> getOrLoadEqualityDeleteFieldIds(
      * miss parses at most once.
      */
     ManifestCacheValue getManifestCacheValue(ManifestFile manifest, Table 
table) {
+        if (requiresStatementRead(manifest, table)) {
+            return loadManifestCacheValue(manifest, table, manifest.content(), 
false);
+        }
         IcebergManifestEntryKey key = IcebergManifestEntryKey.of(manifest);
-        return entry.get(key, k -> loadManifestCacheValue(
+        // A plaintext manifest may reveal file keys only after loading; 
isolate unclassified misses too.
+        return entry.getForLoadScope(key, new Object(), k -> 
loadManifestCacheValue(

Review Comment:
   Implemented in 93a9fdbe3de4. The statement scope now owns a reader bound to 
the frozen table lease, with its stable identity used for in-flight reuse. 
Sync/future/cached-only paths and data/delete reads use that reader; optional 
stats remain per call. Encrypted tables and descriptors bypass shared entries, 
and plaintext publication retains the existing invalidation guard. Completed 
registrations are removed before callbacks, private values stay with current 
consumers, and actual callable leases survive cancellation. Unscoped, rejected 
and losing-reader registrations release their ownership correctly.
   
   Coverage includes same-statement coalescing for data/position/equality keys, 
real encrypted manifests, isolated observer cancellation, cross-statement 
reads, differing wrapped keys, later plaintext cache hits, many consumed 
manifests, registration races and stats. The one-shot adapter baseline fails 
coalescing; the new lifetime tests preserve the existing active-I/O invariant. 
On the rebased candidate, all 2,376 cache/SPI/Iceberg tests pass (11 existing 
skips), as do 163 fresh ASAN native tests, FE Checkstyle, formatting, header 
hygiene and clang-tidy. The actual documentation conflict was resolved while 
retaining master's REST encryption notes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to