suxiaogang223 commented on PR #70704:
URL: https://github.com/apache/doris/pull/70704#issuecomment-6983497366

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#70704
   commit: 7fd65f2a36091cb610631a504635cdbc65bc100c
   base: 3c559f7a52919ee782099045ad85c3be31b684d9
   reviewed_at: 2026-11-18T23:44+08:00
   reviewer: suxiaogang223
   model: gpt-6-astra
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - Prior F-01 is fixed: 
`fe/fe-core/src/main/java/org/apache/doris/datasource/connector/converter/VectorSearchPredicateConverter.java:68-73`
 rejects negated null-safe equality before recursive lowering; all-NULL and 
mixed-partition TVF rejection gates now cover the trigger.
   - Prior F-02 is fixed: 
`be/src/format_v2/table/paimon_rust_table_reader.cpp:1086-1101` restores 
ordinary physical-name predicate registration; the selective INT regression 
requires actual native predicate conversion and application.
   - 
`fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindExpression.java:1929-1949`
 deliberately places default postfilter after global TopN. Scoped equivalence 
to original4.2 retains supported inputs, scores, aliases, pins and source 
coverage; prepared TVF property placeholders remain a preexisting target-master 
parser limitation.
   - `be/src/format_v2/table/paimon_rust_table_reader.cpp:289-312` 
eager-materialization memory budgeting is expressly deferred. This read-only 
review inspected inherited build/test logs and did not execute builds or tests.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to