suxiaogang223 commented on PR #70704:
URL: https://github.com/apache/doris/pull/70704#issuecomment-6984491197
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70704
commit: e991754eeaf41193eb09c8b72a6a2a344bfa6f84
base: b706e7574814cfc8fcb412c481a6166f7ce3c9cc
reviewed_at: 2026-11-19T00:21+08:00
reviewer: suxiaogang223
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `fe/fe-connector/pom.xml:58` — API 35 combines the current master API 34
surface with vector additions; endpoint/path-key methods remain, and one
property feeds the kernel resource and plugin manifests.
-
`fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:2698-2707`
— Paimon keeps the default path-key fallback, pinned handles and captured
filter slots; vector parameters still reach every applicable scan path. BLOB
fields 21–23 coexist with vector payload 24.
-
`fe/fe-core/src/main/java/org/apache/doris/datasource/connector/converter/VectorSearchPredicateConverter.java:68-73`
— Prior F-01 remains fixed: reject negated null-safe equality before recursive
lowering. The real all-NULL/mixed-partition TVF rejection gate remains intact.
- `be/src/format_v2/table/paimon_rust_table_reader.cpp:1095-1101` — Prior
F-02 remains fixed: ordinary physical columns retain native predicate pushdown;
vector synthetic-column exclusion stays separate. The selective physical-name
profile gate is unchanged.
- Fresh development evidence: 167 SPI tests in 38 classes passed, plus FE
compilation and SPI Checkstyle. Full BE build/native64/runtime6 evidence is
inherited from 7fd65f2, not rerun after this merge. Review was read-only.
Eager-memory budgeting remains deferred; prepared TVF property placeholders
remain a target-master baseline limitation, and global postfilter placement
intentionally corrects the original 4.2 behavior.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]