tuantran0910 commented on PR #62988:
URL: https://github.com/apache/doris/pull/62988#issuecomment-7000012946

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#62988
   commit: 0af912b7decabeded32a494c71debc02c16674ac
   base: 25de3bf8cc627ad232d19c41629fe9ef5b03bdfa
   reviewed_at: 2026-11-19T11:48+07:00
   reviewer: tuantran0910
   model: claude-opus-5-5
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 1}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - `fe/be-java-extensions/iceberg-metadata-scanner/pom.xml:91-95` — upgrade 
order: with `iceberg-gcp` in the BE scanner, a
     BE-first upgrade from an Iceberg-1.12 FE build without this change can 
read `$all_manifests` manifest lists of REST
     catalogs over `gs://` through `GCSFileIO` with the BE host's ADC until the 
FE is upgraded (declared in the PR body and
     release note). Released 4.x FEs are unaffected: their system-table splits 
already fail closed on an Iceberg-1.12 BE.
   - 
`fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergCatalogFactory.java:470-473`
     — the `NativeGcsResolvingFileIO` default applies only when a typed GCS 
storage binding is inferred; a REST catalog
     configured with raw `fs.gs.*` keys alone still resolves `gs://` to 
`GCSFileIO`. That case is the open review thread
     r4623541395 and is not settled by this pass.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to