tuantran0910 commented on PR #62988:
URL: https://github.com/apache/doris/pull/62988#issuecomment-7003997513

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#62988
   commit: e4bf941b2b9f37b5f73972e4f38f449388d4504d
   base: 25de3bf8cc627ad232d19c41629fe9ef5b03bdfa
   reviewed_at: 2026-11-19T15:34+07:00
   reviewer: tuantran0910
   model: claude-opus-5-5
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - No finding is flagged as a regression against the merge base.
   - 
`fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergCatalogFactory.java:504-510`:
 the raw `fs.gs.*` default for REST catalogs now has a negative test 
(`fe/fe-connector/fe-connector-iceberg/src/test/java/org/apache/doris/connector/iceberg/IcebergCatalogFactoryTest.java:994-1011`).
 It covers hms, hadoop, jdbc and glue, which are every non-REST flavor that 
reaches this code; dlf and s3tables are built by other paths.
   - REST catalogs with no GCS configuration at all still resolve `gs://` to 
`GCSFileIO` with ADC, where the merge base used `HadoopFileIO`. The author kept 
the default gated on `fs.gs.*` keys so it does not replace a REST server's 
`/v1/config` `io-impl`; maintainers may want to settle that trade-off on thread 
r4623541395.
   - The pinned `io-impl` defaults are client properties, so they replace an 
`io-impl` that a REST server sends in its `/v1/config` `defaults` (Apache 
Gravitino does). The PR body declares this, and setting `iceberg.rest.io-impl` 
keeps the server's choice.
   - `security.type=google` is covered by unit tests only. No test exercises 
live Google OAuth or a BigLake endpoint.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to