yujun777 commented on PR #69896:
URL: https://github.com/apache/doris/pull/69896#issuecomment-7004564199

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#69896
   commit: a266e6acc29f17203dff72e9948a1211883a8340
   base: ccfd4378d424292a363a96142ad795b8c9ace21e
   reviewed_at: 2026-11-19T17:02+08:00
   reviewer: yujun777
   model: gpt-6.1-sol
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - 
`fe/fe-core/src/main/java/org/apache/doris/catalog/MaterializedIndex.java:230-257`
 — Each Cloud changelog index lazily tracks at most 1,024 version ranges. At 
capacity all immediate deltas, including bridging versions, are skipped without 
evicting applied-version history. Only an advancing complete report can retire 
covered ranges; updates resume only below the cap. Partial reports cannot 
release capacity.
   - 
`fe/fe-core/src/test/java/org/apache/doris/catalog/MaterializedIndexTest.java:113-145`
 — Supplied development evidence: the new limit test fails before the cap 
(expected 1,024, actual 1,044), then 75 focused FE tests and the FE 
package/Checkstyle build pass. The review inspected these artifacts and the 
pinned Guava 33.2.1-jre implementation; it did not execute builds/tests or 
current-head live SN/cloud E2E.
   - Historical cloud validation remains partial: full changelog_p0 is 24/28; 
test_changelog_before_column_name, test_cloud_changelog_publish_conflict, 
test_changelog_multi_segment and test_changelog_basic all repeat row-content 
failures in isolation. No PR-specific causal changed payload path was 
established, but no merge-base cluster comparison or exact key_detail history 
root cause was proved; these failures are not reported as passing.
   - 
`regression-test/suites/changelog_p0/test_changelog_immediate_row_count.groovy:102-128`
 — Historical two-consumption SN/cloud runs pass with publication paused and 
preserve current counts 3/4 across consumption. Those runs used existing 
binaries reporting 1f556 and do not prove exact current production-binary 
equivalence. Consumer PR #69850 combined runtime and a performance benchmark 
remain untested; estimates retain their declared report-overlap/lag 
approximation.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to