yujun777 commented on PR #69850:
URL: https://github.com/apache/doris/pull/69850#issuecomment-7004875959

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#69850
   commit: 965a8aff4099bed4fe599af3a70fc88ecc4043aa
   base: ee73acc6131e6c6c752eb59e252404590be6ad77
   reviewed_at: 2026-11-19T17:16+08:00
   reviewer: yujun777
   model: gpt-6.1-sol
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - 
`fe/fe-core/src/main/java/org/apache/doris/catalog/stream/StreamRowCountEstimator.java:44`
 — counts remain asynchronous approximations; report lag and TTL overlap are 
not a strict TSO-aligned upper bound.
   - Development evidence inspected, not rerun by reviewers: 28 focused FE 
tests passed with zero failures/errors/skips; FE package and Checkstyle passed. 
Earlier 33/116 batches are not added to this current total.
   - Earlier 42 ASAN in-memory MS tests apply to unchanged native/proto/test 
content; 17 SN suites retain earlier-head scope. The new baseline protocol was 
not run on a live Cloud cluster; no real FDB/process restart, true FE failover, 
current combined companion binary or benchmark validation is claimed.
   - `gensrc/proto/cloud.proto:598` — six new FE/MS count fields are optional 
and absent values become unknown; migration of the unreleased local stream/IVM 
JSON format is intentionally omitted.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to