platoneko commented on code in PR #17658:
URL: https://github.com/apache/doris/pull/17658#discussion_r1141248661
##########
be/src/olap/task/engine_storage_migration_task.cpp:
##########
@@ -41,6 +41,12 @@ Status EngineStorageMigrationTask::execute() {
Status EngineStorageMigrationTask::_get_versions(int32_t start_version,
int32_t* end_version,
std::vector<RowsetSharedPtr>*
consistent_rowsets) {
std::shared_lock rdlock(_tablet->get_header_lock());
+ // check if tablet is in cooldown, we don't support migration in this case
+ if (_tablet->tablet_meta()->cooldown_meta_id().initialized()) {
+ LOG(WARNING) << "tablet is in cooldown, not support snapshot. tablet="
+ << _tablet->tablet_id();
+ return Status::NotSupported("tablet is in cooldown, not support
snapshot");
Review Comment:
`currently not support migrate tablet with cooldowned remote data`
##########
be/src/olap/task/engine_storage_migration_task.cpp:
##########
@@ -41,6 +41,12 @@ Status EngineStorageMigrationTask::execute() {
Status EngineStorageMigrationTask::_get_versions(int32_t start_version,
int32_t* end_version,
std::vector<RowsetSharedPtr>*
consistent_rowsets) {
std::shared_lock rdlock(_tablet->get_header_lock());
+ // check if tablet is in cooldown, we don't support migration in this case
+ if (_tablet->tablet_meta()->cooldown_meta_id().initialized()) {
+ LOG(WARNING) << "tablet is in cooldown, not support snapshot. tablet="
+ << _tablet->tablet_id();
+ return Status::NotSupported("tablet is in cooldown, not support
snapshot");
Review Comment:
"currently not support migrate tablet with cooldowned remote data"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
