platoneko commented on code in PR #17658:
URL: https://github.com/apache/doris/pull/17658#discussion_r1141250938
##########
be/src/olap/snapshot_manager.cpp:
##########
@@ -424,8 +437,10 @@ Status SnapshotManager::_create_snapshot_files(const
TabletSharedPtr& ref_tablet
}
}
+ // be would definitely set it as true no matter has missed version
or not need to
+ // add one condition to meet the origin semantic of
__isset.missing_version = false
int64_t version = -1;
- if (!res.ok() || !request.__isset.missing_version) {
+ if (!res.ok() || !request.__isset.missing_version ||
request.missing_version.empty()) {
/// not all missing versions are found, fall back to full
snapshot.
Review Comment:
judge `cooldown_meta_id` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
