dutyu commented on code in PR #18102:
URL: https://github.com/apache/doris/pull/18102#discussion_r1148303563
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/HMSExternalCatalog.java:
##########
@@ -69,6 +77,13 @@ public HMSExternalCatalog(long catalogId, String name,
String resource, Map<Stri
@Override
public void checkProperties() throws DdlException {
super.checkProperties();
+ // check file.meta.cache.ttl-second parameter
+ String fileMetaCacheTtlSecond =
catalogProperty.getOrDefault(FILE_META_CACHE_TTL_SECOND, "");
Review Comment:
User can set `file.meta.cache.ttl-second` = "" and it will pass the check
here, although we will not enable ttl with file cache finally, but i think we
should let user follow the rules(the value of `file.meta.cache.ttl-second` only
can be set as a non-negative number).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
