lexluo09 commented on code in PR #18102:
URL: https://github.com/apache/doris/pull/18102#discussion_r1148307333
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/HMSExternalCatalog.java:
##########
@@ -69,6 +77,13 @@ public HMSExternalCatalog(long catalogId, String name,
String resource, Map<Stri
@Override
public void checkProperties() throws DdlException {
super.checkProperties();
+ // check file.meta.cache.ttl-second parameter
+ String fileMetaCacheTtlSecond =
catalogProperty.getOrDefault(FILE_META_CACHE_TTL_SECOND, "");
Review Comment:
1. In this case, if user set a negative number , the check will not pass.
2. If user set `file.meta.cache.ttl-second` = "", the check will pass and
not enable ttl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
