yiguolei commented on code in PR #18108:
URL: https://github.com/apache/doris/pull/18108#discussion_r1148541128


##########
be/src/exec/line_reader.h:
##########
@@ -28,7 +28,8 @@ class LineReader {
 public:
     virtual ~LineReader() = default;
     virtual Status read_line(const uint8_t** ptr, size_t* size, bool* eof,
-                             const io::IOContext* io_ctx) = 0;
+                             const io::IOContext* io_ctx, size_t* read_bytes = 
nullptr) = 0;

Review Comment:
   I think we should first refactor broker load and use insert into select to 
implement broker load. And then we add scan bytes to all scan node . In this 
way, we will add progress feature to all load types, like stream load, broker 
load, tvf load, insert into select



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to