github-actions[bot] commented on code in PR #18108:
URL: https://github.com/apache/doris/pull/18108#discussion_r1155335026
##########
be/src/vec/exec/format/json/new_json_reader.h:
##########
@@ -141,9 +142,9 @@ class NewJsonReader : public GenericReader {
size_t _column_index(const StringRef& name, size_t key_index);
- Status (NewJsonReader::*_vhandle_json_callback)(Block& block,
- const
std::vector<SlotDescriptor*>& slot_descs,
- bool* is_empty_row, bool*
eof);
+ Status (NewJsonReader::*_vhandle_json _callback)(Block& block,
Review Comment:
warning: private field '_vhandle_json' is not used
[clang-diagnostic-unused-private-field]
```cpp
Status (NewJsonReader::*_vhandle_json _callback)(Block& block,
^
```
##########
be/src/vec/exec/format/json/new_json_reader.h:
##########
@@ -141,9 +142,9 @@
size_t _column_index(const StringRef& name, size_t key_index);
- Status (NewJsonReader::*_vhandle_json_callback)(Block& block,
- const
std::vector<SlotDescriptor*>& slot_descs,
- bool* is_empty_row, bool*
eof);
+ Status (NewJsonReader::*_vhandle_json _callback)(Block& block,
Review Comment:
warning: expected ')' [clang-diagnostic-error]
```cpp
Status (NewJsonReader::*_vhandle_json _callback)(Block& block,
^
```
**be/src/vec/exec/format/json/new_json_reader.h:144:** to match this '('
```cpp
Status (NewJsonReader::*_vhandle_json _callback)(Block& block,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
