This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git
commit f6118b2c0414f31c467ee390a08a0ddbd4f4bedc Author: Lei Zhang <[email protected]> AuthorDate: Thu Mar 16 10:22:42 2023 +0800 [fix](fe) fix drop frontend removeUnReadyElectableNode incorrectly (#17680) * when add two not exist fe and drop two not exit fe, we may meet exception like this: ''' java.lang.IllegalArgumentException: com.sleepycat.je.config.IntConfigParam: param je.rep.electableGroupSizeOverride doesn't validate, -1 is less than min of 0 at com.sleepycat.je.config.IntConfigParam.validate(IntConfigParam.java:47) at com.sleepycat.je.config.IntConfigParam.validateValue(IntConfigParam.java:75) at com.sleepycat.je.dbi.DbConfigManager.setVal(DbConfigManager.java:648) at com.sleepycat.je.dbi.DbConfigManager.setIntVal(DbConfigManager.java:694) at com.sleepycat.je.rep.ReplicationMutableConfig.setElectableGroupSizeOverrideVoid(ReplicationMutableConfig.java:523) at com.sleepycat.je.rep.ReplicationMutableConfig.setElectableGroupSizeOverride(ReplicationMutableConfig.java:512) at org.apache.doris.ha.BDBHA.removeUnReadyElectableNode(BDBHA.java:236) at org.apache.doris.catalog.Env.dropFrontend(Env.java:2533) ''' --- fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java index 9de5c99e28..72e0f4c0bc 100755 --- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java +++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java @@ -2595,7 +2595,7 @@ public class Env { haProtocol.removeElectableNode(fe.getNodeName()); helperNodes.remove(Pair.of(host, port)); BDBHA ha = (BDBHA) haProtocol; - ha.removeUnReadyElectableNode(nodeName, getFollowerCount()); + ha.removeUnReadyElectableNode(fe.getNodeName(), getFollowerCount()); } editLog.logRemoveFrontend(fe); } finally { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
