This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git

commit e572e782cb833e6b98c5a06c9e20eb2b50fd12fd
Author: Lei Zhang <[email protected]>
AuthorDate: Sun Mar 19 11:39:19 2023 +0800

    [fix](fe) fix MetricRepo.THRIFT_COUNTER_RPC_ALL NullPointException (#17552)
---
 .../src/main/java/org/apache/doris/service/FeServer.java      | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java 
b/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
index 11b224df02..32d055069a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/service/FeServer.java
@@ -50,7 +50,9 @@ public class FeServer {
                 (proxy, method, args) -> {
                     long begin = System.currentTimeMillis();
                     String name = method.getName();
-                    
MetricRepo.THRIFT_COUNTER_RPC_ALL.getOrAdd(name).increase(1L);
+                    if (MetricRepo.isInit) {
+                        
MetricRepo.THRIFT_COUNTER_RPC_ALL.getOrAdd(name).increase(1L);
+                    }
                     feServiceLogger.debug("receive request for {}", name);
                     Object r = null;
                     try {
@@ -61,8 +63,11 @@ public class FeServer {
                         throw t;
                     } finally {
                         feServiceLogger.debug("finish process request for {}", 
name);
-                        long end = System.currentTimeMillis();
-                        
MetricRepo.THRIFT_COUNTER_RPC_LATENCY.getOrAdd(name).increase(end - begin);
+                        if (MetricRepo.isInit) {
+                            long end = System.currentTimeMillis();
+                            
MetricRepo.THRIFT_COUNTER_RPC_LATENCY.getOrAdd(name)
+                                    .increase(end - begin);
+                        }
                     }
                     return r;
                 });


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to