github-actions[bot] commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1172539768
##########
be/src/service/internal_service.h:
##########
@@ -91,6 +91,11 @@ class PInternalServiceImpl : public PBackendService {
PTabletWriterOpenResult* response,
google::protobuf::Closure* done) override;
+ void delta_writer_open(google::protobuf::RpcController* controller,
+ const DeltaWriterOpenRequest* request,
+ DeltaWriterOpenResult* response,
+ google::protobuf::Closure* done) override;
Review Comment:
warning: only virtual member functions can be marked 'override'
[clang-diagnostic-error]
```suggestion
google::protobuf::Closure* done) ;
```
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -1183,6 +1184,22 @@ Status VOlapTableSink::send(RuntimeState* state,
vectorized::Block* input_block,
}
// each row
_generate_row_distribution_payload(channel_to_payload, partition,
tablet_index, i, 1);
+ // Lazy open partition
+ const std::vector<OlapTableIndexTablets>& indexs = partition->indexes;
+ std::set<int64_t> index_channels;
+ for (const auto& index : indexs){
+ const auto index_id = index.index_id;
+ index_channels.insert(index_id);
+ }
+ const auto& id = partition->id;
Review Comment:
warning: unused variable 'id' [clang-diagnostic-unused-variable]
```cpp
const auto& id = partition->id;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
