freemandealer commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1173255009
##########
gensrc/proto/internal_service.proto:
##########
@@ -89,6 +89,14 @@ message PTabletWriterOpenResult {
required PStatus status = 1;
};
+message DeltaWriterOpenRequest{
+ repeated int64 index_ids = 1;
+}
+
+message DeltaWriterOpenResult {
+ required PStatus status = 1;
+}
+
Review Comment:
Also add a rpc claim in PBackendService at the bottom of the file
##########
be/src/service/internal_service.h:
##########
@@ -91,6 +91,11 @@ class PInternalServiceImpl : public PBackendService {
PTabletWriterOpenResult* response,
google::protobuf::Closure* done) override;
+ void delta_writer_open(google::protobuf::RpcController* controller,
Review Comment:
rename it to 'partition_open'
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -48,6 +48,8 @@ class LoadChannelMgr {
// open a new load channel if not exist
Status open(const PTabletWriterOpenRequest& request);
+ Status open_delta_writer(const DeltaWriterOpenRequest& params);
Review Comment:
rename
##########
be/src/runtime/load_channel_mgr.cpp:
##########
@@ -120,6 +120,10 @@ Status LoadChannelMgr::open(const
PTabletWriterOpenRequest& params) {
return Status::OK();
}
+Status LoadChannelMgr::open_delta_writer(const DeltaWriterOpenRequest& params)
{
Review Comment:
rename
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
