jihoonson commented on a change in pull request #5857: Optimize filtered aggs 
with interval filters in per-segment queries
URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206301783
 
 

 ##########
 File path: 
processing/src/main/java/io/druid/query/aggregation/AggregatorFactory.java
 ##########
 @@ -141,6 +142,17 @@ public AggregatorFactory 
getMergingFactory(AggregatorFactory other) throws Aggre
    */
   public abstract int getMaxIntermediateSize();
 
+  /**
+   * Return a potentially optimized form of this AggregatorFactory for 
per-segment queries.
+   *
+   * @param optimizationContext
+   * @return
 
 Review comment:
   nit: you can remove `@param` and `@return` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to