jihoonson commented on a change in pull request #5857: Optimize filtered aggs
with interval filters in per-segment queries
URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206302230
##########
File path:
processing/src/main/java/io/druid/query/aggregation/FilteredAggregatorFactory.java
##########
@@ -140,6 +144,61 @@ public int getMaxIntermediateSize()
return delegate.getMaxIntermediateSize();
}
+ @Override
+ public AggregatorFactory
optimizeForSegment(PerSegmentQueryOptimizationContext optimizationContext)
+ {
+ if (filter instanceof IntervalDimFilter) {
+ IntervalDimFilter intervalDimFilter = ((IntervalDimFilter) filter);
+ if (intervalDimFilter.getExtractionFn() != null) {
+ // no support for exfn right now
Review comment:
nit: better to use the full name like `extractionFn` or 'extraction
function'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
