jihoonson commented on a change in pull request #6090: Fix missing exception
handling as part of
`io.druid.java.util.http.client.netty.HttpClientPipelineFactory`
URL: https://github.com/apache/incubator-druid/pull/6090#discussion_r207673625
##########
File path:
java-util/src/main/java/io/druid/java/util/http/client/pool/ChannelResourceFactory.java
##########
@@ -109,6 +112,28 @@ public ChannelFuture generate(final String hostname)
final ChannelPipeline pipeline =
connectFuture.getChannel().getPipeline();
pipeline.addFirst("ssl", sslHandler);
+ pipeline.addFirst("handler", new SimpleChannelUpstreamHandler()
Review comment:
I think this handler should be responsible for only connection errors. Every
other errors should be handled by the handler in `NettyHttpClient` to properly
notify callers on failures.
So, please rename the handler to be more intuitive like
`connectionErrorHandler`. Also, this handler should be after `sslHandler` to
catch all exceptions properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
