jihoonson commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210107813
########## File path: extensions-contrib/kafka-eight-simpleConsumer/src/main/java/io/druid/firehose/kafka/KafkaEightSimpleConsumerFirehoseFactory.java ########## @@ -72,7 +73,7 @@ private final List<PartitionConsumerWorker> consumerWorkers = new CopyOnWriteArrayList<>(); private static final int DEFAULT_QUEUE_BUFFER_LENGTH = 20000; - private static final int CONSUMER_FETCH_TIMEOUT = 10000; + private static final int CONSUMER_FETCH_TIMEOUT_MILLIS = (int) TimeUnit.SECONDS.toMillis(10); Review comment: `long` makes more sense to me. Would you please change the type as well? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
