jihoonson commented on a change in pull request #6158: Make time-related
variables more readable
URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210107682
##########
File path:
extensions-contrib/ambari-metrics-emitter/src/main/java/io/druid/emitter/ambari/metrics/AmbariMetricsEmitterConfig.java
##########
@@ -25,13 +25,13 @@
import java.util.Collections;
import java.util.List;
-
+import java.util.concurrent.TimeUnit;
public class AmbariMetricsEmitterConfig
{
private static final int DEFAULT_BATCH_SIZE = 100;
- private static final Long DEFAULT_FLUSH_PERIOD_MILLIS = (long) (60 * 1000);
// flush every one minute
- private static final long DEFAULT_GET_TIMEOUT = 1000; // default wait for
get operations on the queue 1 sec
+ private static final Long DEFAULT_FLUSH_PERIOD_MILLIS =
TimeUnit.MINUTES.toMillis(1); // flush every one minute
Review comment:
We can use `long`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
