gianm commented on a change in pull request #6185: 'shutdownAllTasks' API for a
dataSource
URL: https://github.com/apache/incubator-druid/pull/6185#discussion_r210971130
##########
File path:
indexing-service/src/main/java/io/druid/indexing/overlord/http/OverlordResource.java
##########
@@ -337,6 +337,28 @@ public Response apply(TaskQueue taskQueue)
);
}
+ @POST
+ @Path("/task/{dataSource}/shutdownAllTasks")
+ @Produces(MediaType.APPLICATION_JSON)
+ public Response shutdownTasksForDataSource(@PathParam("dataSource") final
String dataSource)
+ {
+ return asLeaderWith(
+ taskMaster.getTaskQueue(),
+ new Function<TaskQueue, Response>()
+ {
+ @Override
+ public Response apply(TaskQueue taskQueue)
+ {
+ final List<TaskInfo<Task, TaskStatus>> tasks =
taskStorageQueryAdapter.getActiveTaskInfo(dataSource);
+ for (final TaskInfo<Task, TaskStatus> task : tasks) {
Review comment:
Agree that it's good to be consistent within a file, and the rest of this
file is totally down with for loops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
