jihoonson commented on a change in pull request #6162: Add maven.exec.xxx.skip 
option for exec-maven-plugin
URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r210688935
 
 

 ##########
 File path: docs/content/development/build.md
 ##########
 @@ -22,7 +22,7 @@ mvn clean package
 This will compile the project and create the Druid binary distribution tar 
under
 `distribution/target/druid-VERSION-bin.tar.gz`.
 
-This will also create a tarball that contains `mysql-metadata-storage` 
extension under 
+After adding `-Pdist` option, this will also create a tarball that contains 
`mysql-metadata-storage` extension under 
 
 Review comment:
   We need to add more details about this option. The document should say what 
this option means and how different `mvn clean install` and `mvn clean install 
-Pdist` are. Also, please update [this 
command](https://github.com/apache/incubator-druid/pull/6162/files#diff-15788e24b4299e22aff8aba2ea46281fR19)
 to `mvn clean install -Pdist`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to