jihoonson commented on a change in pull request #6129: Add support for
'maxTotalRows' to incremental publishing kafka indexing task and appenderator
based realtime task
URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r212159646
##########
File path:
server/src/main/java/io/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -1119,15 +1096,16 @@ public String apply(SegmentIdentifier input)
)
{
// Ensure no future writes will be made to this sink.
- sink.finishWriting();
+ if (sink.finishWriting()) {
+ // Decrement this sink's rows from rowsCurrentlyInMemory (we only count
active sinks).
+ rowsCurrentlyInMemory.addAndGet(-sink.getNumRowsInMemory());
Review comment:
Hmm, is this valid? It looks that this would not be called if
[this](https://github.com/apache/incubator-druid/pull/6129/files#diff-940e5274e2cfb880c70e6249ea864f63R605)
is executed first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
