jihoonson commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r212156381
########## File path: extensions-core/kafka-indexing-service/src/main/java/io/druid/indexing/kafka/KafkaTuningConfig.java ########## @@ -40,6 +40,7 @@ private final int maxRowsInMemory; private final long maxBytesInMemory; private final int maxRowsPerSegment; + private final Long maxTotalRows; Review comment: Please add `@Nullable`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
