leventov commented on a change in pull request #6220: Fix four bugs with
numeric dimension output types.
URL: https://github.com/apache/incubator-druid/pull/6220#discussion_r212516457
##########
File path:
processing/src/main/java/io/druid/query/topn/PooledTopNAlgorithm.java
##########
@@ -749,14 +743,9 @@ protected void updateResults(
position += aggregatorSizes[j];
}
- Object retVal = dimSelector.lookupName(i);
- if (needsResultConversion) {
- retVal = valueTransformer.apply(retVal);
- }
-
-
+ // Output type must be STRING in order for PooledTopNAlgorithm to make
sense; so no need to convert value.
Review comment:
Maybe add an assert about the output type here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
