leventov commented on a change in pull request #6220: Fix four bugs with 
numeric dimension output types.
URL: https://github.com/apache/incubator-druid/pull/6220#discussion_r212517826
 
 

 ##########
 File path: 
processing/src/main/java/io/druid/query/topn/types/StringTopNColumnSelectorStrategy.java
 ##########
 @@ -126,7 +119,7 @@ private long 
dimExtractionScanAndAggregateWithCardinalityKnown(
       Cursor cursor,
       DimensionSelector selector,
       Aggregator[][] rowSelector,
-      Map<String, Aggregator[]> aggregatesStore
+      Map<Comparable, Aggregator[]> aggregatesStore
 
 Review comment:
   `Comparable` and `Comparable<?>` are used inconsistently in this class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to