clintropolis commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r217680616
########## File path: extensions-core/datasketches/src/main/java/io/druid/query/aggregation/datasketches/hll/HllSketchBuildAggregator.java ########## @@ -0,0 +1,113 @@ +/* + * Licensed to Metamarkets Group Inc. (Metamarkets) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. Metamarkets licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package io.druid.query.aggregation.datasketches.hll; + +import com.yahoo.sketches.hll.HllSketch; +import com.yahoo.sketches.hll.TgtHllType; + +import io.druid.java.util.common.IAE; +import io.druid.query.aggregation.Aggregator; +import io.druid.segment.ColumnValueSelector; + +/** + * This aggregator builds sketches from raw data. + * The input column can contain identifiers of type string, char[], byte[] or any numeric type. + * @author Alexander Saydakov + */ +public class HllSketchBuildAggregator implements Aggregator +{ + + private final ColumnValueSelector<Object> selector; + private HllSketch sketch; + + public HllSketchBuildAggregator(final ColumnValueSelector<Object> selector, final int lgK, final TgtHllType tgtHllType) + { + this.selector = selector; + sketch = new HllSketch(lgK, tgtHllType); Review comment: nit: `this.sketch = ...` to be consistent with other assignment in constructors ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
