clintropolis commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r217681599
########## File path: extensions-core/datasketches/src/main/java/io/druid/query/aggregation/datasketches/hll/HllSketchModule.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to Metamarkets Group Inc. (Metamarkets) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. Metamarkets licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package io.druid.query.aggregation.datasketches.hll; + +import java.util.Arrays; +import java.util.List; + +import com.fasterxml.jackson.databind.Module; +import com.fasterxml.jackson.databind.jsontype.NamedType; +import com.fasterxml.jackson.databind.module.SimpleModule; +import com.google.inject.Binder; +import com.yahoo.sketches.hll.HllSketch; + +import io.druid.initialization.DruidModule; +import io.druid.segment.serde.ComplexMetrics; + +/** + * This module is to support count-distinct operations using {@link HllSketch}. + * See <a href="https://datasketches.github.io/docs/HLL/HLL.html";>HyperLogLog Sketch documentation</a> + * @author Alexander Saydakov + */ +public class HllSketchModule implements DruidModule Review comment: This needs an entry to be added to `META-INF/services/io.druid.initialization.DruidModule`, `io.druid.query.aggregation.datasketches.hll.HllSketchModule` in order for this module to operate properly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
