[incubator-druid] branch master updated: fix incorrect precondition check in `SupervisorManager.suspendOrResumeSupervisor` (#6364)

[jonwei]

This is an automated email from the ASF dual-hosted git repository.

jonwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 399a565  fix incorrect precondition check in 
`SupervisorManager.suspendOrResumeSupervisor` (#6364)
399a565 is described below

commit 399a5659b238ffd0660a98fb5ea7980ccc7b8ab2
Author: Clint Wylie <cjwy...@gmail.com>
AuthorDate: Fri Sep 21 17:40:14 2018 -0700

    fix incorrect precondition check in 
`SupervisorManager.suspendOrResumeSupervisor` (#6364)
    
    This check is reverse from the intention
---
 .../apache/druid/indexing/overlord/supervisor/SupervisorManager.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java
 
b/indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java
index cca6fe5..22fd827 100644
--- 
a/indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java
+++ 
b/indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java
@@ -95,7 +95,7 @@ public class SupervisorManager
   {
     Preconditions.checkState(started, "SupervisorManager not started");
     Pair<Supervisor, SupervisorSpec> pair = supervisors.get(id);
-    Preconditions.checkNotNull(pair.lhs, "spec");
+    Preconditions.checkNotNull(pair.rhs, "spec");
     synchronized (lock) {
       Preconditions.checkState(started, "SupervisorManager not started");
       SupervisorSpec nextState = suspend ? pair.rhs.createSuspendedSpec() : 
pair.rhs.createRunningSpec();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org