jon-wei closed pull request #6364: fix incorrect precondition check in SupervisorManager.suspendOrResumeSupervisor URL: https://github.com/apache/incubator-druid/pull/6364
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java b/indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java index cca6fe51bd8..22fd82746a7 100644 --- a/indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java +++ b/indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java @@ -95,7 +95,7 @@ public boolean suspendOrResumeSupervisor(String id, boolean suspend) { Preconditions.checkState(started, "SupervisorManager not started"); Pair<Supervisor, SupervisorSpec> pair = supervisors.get(id); - Preconditions.checkNotNull(pair.lhs, "spec"); + Preconditions.checkNotNull(pair.rhs, "spec"); synchronized (lock) { Preconditions.checkState(started, "SupervisorManager not started"); SupervisorSpec nextState = suspend ? pair.rhs.createSuspendedSpec() : pair.rhs.createRunningSpec(); ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org