leventov commented on a change in pull request #6402: Thread-safe QueryMetrics
URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r222057444
##########
File path:
processing/src/main/java/org/apache/druid/query/GroupByMergedQueryRunner.java
##########
@@ -114,10 +113,10 @@ public Void call()
{
try {
if (bySegment) {
- input.run(threadSafeQueryPlus, responseContext)
+ input.run(queryPlus.withQueryMetricsCopied(),
responseContext)
Review comment:
Previously there were no QueryMetrics object in threadSafeQueryPlus, it will
throw NPE if somebody tries to emit some metrics by mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
