egor-ryashin commented on a change in pull request #6349: maintenance mode for 
Historical
URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r222824789
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
 ##########
 @@ -100,8 +101,12 @@ public CoordinatorDynamicConfig(
     this.killDataSourceWhitelist = 
parseJsonStringOrArray(killDataSourceWhitelist);
     this.killPendingSegmentsSkipList = 
parseJsonStringOrArray(killPendingSegmentsSkipList);
     this.maxSegmentsInNodeLoadingQueue = maxSegmentsInNodeLoadingQueue;
-    this.maintenanceList = parseJsonStringOrArray(maintenanceList);
-    this.maintenanceModeSegmentsPriority = Math.min(10, Math.max(0, 
maintenanceModeSegmentsPriority));
+    this.historicalNodesInMaintenance = 
parseJsonStringOrArray(historicalNodesInMaintenance);
+    Preconditions.checkArgument(
+        nodesInMaintenancePriority >= 0 && nodesInMaintenancePriority <= 10,
 
 Review comment:
   It allows to suppress maintenance for a time, without clearing the 
maintenance list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to