leventov commented on a change in pull request #6349: maintenance mode for 
Historical
URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r222833912
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/server/coordinator/rules/LoadRule.java
 ##########
 @@ -152,9 +152,8 @@ private void assign(
       log.makeAlert("Tier[%s] has no servers! Check your cluster 
configuration!", tier).emit();
       return Collections.emptyList();
     }
-    predicate = predicate.and(s -> !s.isMaintenance());
-
-    return queue.stream().filter(predicate).collect(Collectors.toList());
+    Predicate<ServerHolder> general = s -> !s.isInMaintenance();
 
 Review comment:
   isGeneral is the same as current general, just more conventional name for a 
Predicate object

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to