This is an automated email from the ASF dual-hosted git repository.

jonwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 868ebfa  Handle case when ignoreInvalidRows is null (#6420)
868ebfa is described below

commit 868ebfaca087f7c9018996d81fa321b523e8dc06
Author: Atul Mohan <[email protected]>
AuthorDate: Fri Oct 5 13:03:37 2018 -0500

    Handle case when ignoreInvalidRows is null (#6420)
---
 .../src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java    | 4 ++--
 integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
 
b/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
index 502066c..405e5d6 100644
--- 
a/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
+++ 
b/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
@@ -152,11 +152,11 @@ public class HadoopTuningConfig implements TuningConfig
     this.allowedHadoopPrefix = allowedHadoopPrefix == null ? 
ImmutableList.of() : allowedHadoopPrefix;
 
 
-    this.ignoreInvalidRows = ignoreInvalidRows;
+    this.ignoreInvalidRows = ignoreInvalidRows == null ? false : 
ignoreInvalidRows;
     if (maxParseExceptions != null) {
       this.maxParseExceptions = maxParseExceptions;
     } else {
-      if (ignoreInvalidRows == null || !ignoreInvalidRows) {
+      if (!this.ignoreInvalidRows) {
         this.maxParseExceptions = 0;
       } else {
         this.maxParseExceptions = TuningConfig.DEFAULT_MAX_PARSE_EXCEPTIONS;
diff --git 
a/integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json 
b/integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json
index 265e07b..adcc60b 100644
--- a/integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json
+++ b/integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json
@@ -6,7 +6,7 @@
       "parser": {
         "type": "string",
         "parseSpec": {
-          "type": "tsv",
+          "format": "tsv",
           "timestampSpec": {
             "column": "timestamp",
             "format": "yyyyMMddHH"


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to