jon-wei closed pull request #6420: Fix hadoop task failure when
ignoreInvalidRows is null
URL: https://github.com/apache/incubator-druid/pull/6420
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
b/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
index 502066ce1de..405e5d60fb1 100644
---
a/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
+++
b/indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
@@ -152,11 +152,11 @@ public HadoopTuningConfig(
this.allowedHadoopPrefix = allowedHadoopPrefix == null ?
ImmutableList.of() : allowedHadoopPrefix;
- this.ignoreInvalidRows = ignoreInvalidRows;
+ this.ignoreInvalidRows = ignoreInvalidRows == null ? false :
ignoreInvalidRows;
if (maxParseExceptions != null) {
this.maxParseExceptions = maxParseExceptions;
} else {
- if (ignoreInvalidRows == null || !ignoreInvalidRows) {
+ if (!this.ignoreInvalidRows) {
this.maxParseExceptions = 0;
} else {
this.maxParseExceptions = TuningConfig.DEFAULT_MAX_PARSE_EXCEPTIONS;
diff --git
a/integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json
b/integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json
index 265e07b0601..adcc60b4256 100644
--- a/integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json
+++ b/integration-tests/src/test/resources/hadoop/batch_hadoop_indexer.json
@@ -6,7 +6,7 @@
"parser": {
"type": "string",
"parseSpec": {
- "type": "tsv",
+ "format": "tsv",
"timestampSpec": {
"column": "timestamp",
"format": "yyyyMMddHH"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
