gianm commented on a change in pull request #6419: Add ability to specify dbcp properties file URL: https://github.com/apache/incubator-druid/pull/6419#discussion_r223505104
########## File path: docs/content/dependencies/metadata-storage.md ########## @@ -32,6 +32,23 @@ See [mysql-metadata-storage extension documentation](../development/extensions-c See [postgresql-metadata-storage](../development/extensions-core/postgresql.html). +## Adding custom dbcp properties + +NOTE: These properties would not be settable through the dbcp properties file: username, password, connectURI, validationQuery, testOnBorrow Review comment: I think it'd be clearer to write this like: > NOTE: These properties are not settable through the DBCP properties file: username, password, connectURI, validationQuery, testOnBorrow. These must be set through `druid.metadata.storage.connector` properties. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
