gianm commented on a change in pull request #6419: Add ability to specify dbcp
properties file
URL: https://github.com/apache/incubator-druid/pull/6419#discussion_r223502912
##########
File path:
common/src/main/java/org/apache/druid/metadata/MetadataStorageConnectorConfig.java
##########
@@ -86,9 +112,15 @@ public String toString()
", connectURI='" + getConnectURI() + '\'' +
", user='" + user + '\'' +
", passwordProvider=" + passwordProvider +
+ ", dbcpPropertiesFile=" + dbcpPropertiesFile +
'}';
}
+ String getDbcpPropertiesFile()
Review comment:
It can help to add `@VisibleForTesting` in situations like this, so readers
understand why a method is neither public nor private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
