clintropolis opened a new pull request #6444: fixes for LookupReferencesManagerTest URL: https://github.com/apache/incubator-druid/pull/6444 `testDisableLookupSync` was not actually testing sync behavior disabled, and had the incorrect url specified in the mock expect, causing it to just spin forever in retry utils instead of test the behavior. `testLoadLookupOnCoordinatorFailure` was doing the correct thing, but a hard coded 60 second timeout in `LookupReferencesManager` was causing it to spin for an extra minute each retry loop. I refactored the hard coded value to be a property on `LookupConfig` that defaults to 60 seconds (mainly so that tests could override, but also just to not be hard coded).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
