himanshug commented on a change in pull request #6381: datsketches extension
updated to use the latest sketches-core-0.12.0
URL: https://github.com/apache/incubator-druid/pull/6381#discussion_r224872813
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregator.java
##########
@@ -42,7 +42,7 @@ public SketchAggregator(BaseObjectColumnValueSelector
selector, int size)
private void initUnion()
{
- union = new SynchronizedUnion((Union)
SetOperation.builder().setNominalEntries(size).build(Family.UNION));
+ union = (Union)
SetOperation.builder().setNominalEntries(size).build(Family.UNION);
Review comment:
you're right , Now I notice that updateUnion(..) is also called from
synchronized block. nvmnd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
