himanshug commented on a change in pull request #6381: datsketches extension updated to use the latest sketches-core-0.12.0 URL: https://github.com/apache/incubator-druid/pull/6381#discussion_r224874727
########## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/LittleEndianWrapper.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation.datasketches; + +import java.nio.ByteBuffer; +import java.nio.ByteOrder; + +import com.yahoo.memory.Memory; +import com.yahoo.memory.WritableMemory; + +public class LittleEndianWrapper +{ + + public static Memory wrap(final ByteBuffer buf) + { + final ByteOrder originalOrder = buf.order(); + final Memory mem = Memory.wrap(buf.order(ByteOrder.LITTLE_ENDIAN)); Review comment: so, are we saying that sketch objects are "always" serialized in little endian and when druid loads those bytes in the ByteBuffer, the order is big endian (jvm default) and that needs to be corrected and memory doesn't know that it is getting a sketch object and wouldn't be able to correctly handle the contents ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
