dclim commented on a change in pull request #6482: Apache-ize POM
URL: https://github.com/apache/incubator-druid/pull/6482#discussion_r226053096
##########
File path: distribution/src/assembly/assembly.xml
##########
@@ -223,8 +223,16 @@
<includes>
<include>LICENSE</include>
<include>NOTICE</include>
+ <include>DISCLAIMER</include>
</includes>
</fileSet>
+ <fileSet>
+ <directory>${project.build.directory}</directory>
+ <includes>
+ <include>git.version</include>
Review comment:
@gianm yeah, I agree that it might be a bit much for a binary release. I was
primarily concerned with being able to differentiate between different RC
versions since we lost that ability by not being able to use different versions
for RCs. Let's say we roll out an RC2 over a cluster that was running RC1 to
fix a bug, and we notice the bug is still happening on one server. It would be
harder without versioning information to realize that the actual issue was that
the deploy from RC1->RC2 failed on that machine.
Thoughts?
I'm on the fence and would be okay removing it. Maybe it would be better to
reduce the amount of info in there to just the commit ID or nearest tag or
whatever and bury it away deeper?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
