dclim commented on a change in pull request #6482: Apache-ize POM
URL: https://github.com/apache/incubator-druid/pull/6482#discussion_r226088059
##########
File path: distribution/src/assembly/assembly.xml
##########
@@ -223,8 +223,16 @@
<includes>
<include>LICENSE</include>
<include>NOTICE</include>
+ <include>DISCLAIMER</include>
</includes>
</fileSet>
+ <fileSet>
+ <directory>${project.build.directory}</directory>
+ <includes>
+ <include>git.version</include>
Review comment:
@gianm okay, I decided for the binary, to bury the revision information
inside MANIFEST.MF in the JARs. So the manifest file looks like this (bold
lines are the ones I added):
Manifest-Version: 1.0
Implementation-Title: druid-indexing-service
Implementation-Version: 0.13.0-incubating-SNAPSHOT
**Build-Timestamp: 2018-10-17T20:34:23+0000**
Built-By: david
Specification-Vendor: The Apache Software Foundation
Specification-Title: druid-indexing-service
Implementation-Vendor-Id: org.apache.druid
Implementation-Vendor: The Apache Software Foundation
**Build-Revision: `7b51d548afc298b37adf147c5f1eef8c3fcb2f3c`**
**Build-Revision-Describe: druid-0.8.0-rc1-3360-g7b51d54-dirty**
**Build-OS: Mac OS X x86_64 10.13.6**
Created-By: Apache Maven 3.3.3
Specification-Version: 0.13
Implementation-URL: https://druid.apache.org/druid-indexing-service/
**Build-Jdk: 1.8.0_162 (Oracle Corporation 25.162-b12)**
**Build-Version: 0.13.0-incubating-SNAPSHOT**
Does that seem okay to you? I also want to fix `Implementation-URL` since
it's getting interpolated to something that doesn't exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
