drcrallen commented on a change in pull request #6482: Apache-ize POM
URL: https://github.com/apache/incubator-druid/pull/6482#discussion_r226099893
##########
File path: pom.xml
##########
@@ -88,9 +100,11 @@
<caffeine.version>2.5.5</caffeine.version>
<!-- When upgrading ZK, edit docs and integration tests as well
(integration-tests/docker-base/setup.sh) -->
<zookeeper.version>3.4.11</zookeeper.version>
- <repoOrgId>org-apache-id</repoOrgId>
- <repoOrgName>org-apache-name</repoOrgName>
-
<repoOrgUrl>https://repository.apache.org/content/repositories/public/</repoOrgUrl>
+ <repoOrgId>apache.snapshots</repoOrgId>
+ <repoOrgName>Apache Snapshot Repository</repoOrgName>
+ <repoOrgUrl>https://repository.apache.org/snapshots</repoOrgUrl>
+ <repository.nightly.id>central-local</repository.nightly.id>
+
<repository.nightly.url>https://metamx.artifactoryonline.com/metamx/pub-libs-releases-local</repository.nightly.url>
Review comment:
I suggest we get rid of it unless its an apache thing. Ideally any company
(including Snap or MMX or others) that need their own nightly builds should be
able to have a not-in-master way of building it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
