leventov commented on a change in pull request #6402: Thread-safe QueryMetrics
URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r229730662
##########
File path:
processing/src/main/java/org/apache/druid/query/ChainedExecutionQueryRunner.java
##########
@@ -116,7 +115,7 @@ public ChainedExecutionQueryRunner(
public Iterable<T> call()
{
try {
- Sequence<T> result =
input.run(threadSafeQueryPlus, responseContext);
+ Sequence<T> result =
input.run(queryPlus.withoutQueryMetrics(), responseContext);
Review comment:
Ok I see, there is at least one reason for doing this, is to not emit
queryCpuTime metrics twice, see
https://github.com/apache/incubator-druid/pull/1696#discussion_r229729305. It
works relying on a crazy combination of side effects, without a single comment.
It requires a refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
