gianm commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types URL: https://github.com/apache/incubator-druid/pull/6505#issuecomment-442250920 Hi @a2l007 - this patch looks good, but it should have a test. Could you please add one? GroupByQueryRunnerTest is probably the right test file to add it to.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
