clintropolis opened a new pull request #6691: remove AbstractResourceFilter.isApplicable because it is not URL: https://github.com/apache/incubator-druid/pull/6691 `AbstractResourceFilter.isApplicable` was added in [#2424](https://github.com/apache/incubator-druid/pull/2424#pullrequestreview-180097275) but it would appear that it was never wired up to anything. It doesn't appear to be necessary, so I have removed it to reduce confusion and lower maintenance overhead to not require any consumer of an `AbstractResourceFilter` implementation to add it's url prefix to the filter in order for it to behave as intended were this code path actually in place. This PR also adds tests for `OverlordResource.doShutdown` and `OverlordResource.shutdownTasksForDatasource` as a follow up to #6686.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
